Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: assets can't include directories #939

Closed
thomasp85 opened this issue Dec 20, 2018 · 4 comments · Fixed by #1033

Comments

@thomasp85
Copy link
Member

commented Dec 20, 2018

It would be nice to be able to have directories in the assets location in order to better organise the additional assets. Currently I get this

Copying 'pkgdown/assets/images' to 'images'
Error : [EISDIR] Failed to copy '/home/travis/build/thomasp85/gganimate/pkgdown/assets/images' to '/tmp/RtmpYIWlqe/file55306a496d1e/images': illegal operation on a directory
Error: [EISDIR] Failed to copy '/home/travis/build/thomasp85/gganimate/pkgdown/assets/images' to '/tmp/RtmpYIWlqe/file55306a496d1e/images': illegal operation on a directory

when setting assets to pkgdown/assets/ and having an images folder in it

@jayhesselberth

This comment has been minimized.

Copy link
Collaborator

commented Dec 20, 2018

@hadley can chime in but my impression is that the pkgdown directory is intended for configuration assets. If you have static images, they can be included in the site by placing them in man/figures.

@thomasp85

This comment has been minimized.

Copy link
Member Author

commented Dec 20, 2018

This was just an example. There are lots of potential assets you may want to include in the site that don’t fit into man/figures (and this was for a md file in the .github directory so it seemed like bad practice to put it there anyway).

In general I’m asking that any folder pointed to by template$assets is allowed to contain subfolders

@ijlyttle

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

Hi, just to add my two cents: I think that this capability would be useful to create datasets packages, publishing the data (or larger versions of the data than one might distribute in the package itself) using GitHub Pages.

If you permitted, or made it easier, to put arbitrary content in pkgdown/assets/, then I could make datasets available, while keeping the pkgdown documentation-goodness.

I realize that this may be scope-creep, but this capability would let me keep all of my "stuff" in one place.

@hadley

This comment has been minimized.

Copy link
Member

commented May 17, 2019

Yeah, I think it's fine for the assets to include directories; it's just a matter of tweaking the coping code.

ijlyttle added a commit to ijlyttle/pkgdown that referenced this issue May 18, 2019
jayhesselberth added a commit that referenced this issue Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.