Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Since package title might not always be appropriate (since CRAN might require quoting)
The text was updated successfully, but these errors were encountered:
Ah something else I'd like to see implemented! Would it be ok to make it work via a title field of the config?
Then in data_home()
pagetitle = pkg$desc$get("Title")[]
pagetitle = pkg$meta[["title"]] %||% pkg$desc$get("Title")[]
If so I can make a PR.
Sorry, something went wrong.
This has to be re-opened cf #1005 (comment): my implementation used a param name that was already used for something else, so I've opened a PR removing my changes as requested by @jayhesselberth.
I suggest we make it a subcomponent of home:
title: "This is my package title"
Btw would a similar parameter for "og:description" make sense? The Description field from DESCRIPTION also contains quotes.
I mean tweaking
opengraph = list(description = pkg$desc$get("Description")[])
opengraph = list(description = pkg$meta$home[["description"]] %||% pkg$desc$get("Description")[])
I can open a separate issue (or add that to my open PR) if of interest.
Would it be too extreme for pkgdown to unquote all quoted words of Title and Description (uncranify them) by default? Only for the ' quotes. Users might still want to use the home fields in config for more customization (or to requote words). 🤔
Oh yes, that's a good idea!
Successfully merging a pull request may close this issue.