Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sticky navbar in css #1016

Merged
merged 3 commits into from May 14, 2019

Conversation

@Bisaloo
Copy link
Contributor

commented May 10, 2019

See https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Scroll-linked_effects

Not entirely sure I did everything right so feel free to test more before merging (I will do the same on my end).

@Bisaloo Bisaloo force-pushed the Bisaloo:sticky-css branch from 010312c to b00f559 May 10, 2019

@jayhesselberth

This comment has been minimized.

Copy link
Collaborator

commented May 10, 2019

This works for me on Chrome. Can you check a few other browsers?

@Bisaloo

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

I worked with Firefox. I can tests on other browsers tomorrow. Feel free to ping me again if I forget again and nothing happens in the next couple of days.

Note to self: looks like the webkit- prefix is still necessary for most safari versions: https://caniuse.com/#feat=css-sticky

@Bisaloo Bisaloo force-pushed the Bisaloo:sticky-css branch from b00f559 to 752336f May 13, 2019

@Bisaloo

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

Tested on Firefox, Chromium and midori (based on an old webkit version). It looks fine.

@Bisaloo Bisaloo force-pushed the Bisaloo:sticky-css branch from 752336f to 044f96b May 13, 2019

@Bisaloo

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

Tested on latest safari version as well (12.1) and it works fine with the -webkit- prefix.

@jayhesselberth jayhesselberth requested a review from hadley May 14, 2019

@jayhesselberth

This comment has been minimized.

Copy link
Collaborator

commented May 14, 2019

In general I am in favor of relying less on external libraries for the site. Looks fine to me.

@hadley
hadley approved these changes May 14, 2019
Copy link
Member

left a comment

Looks good to me. I also checked it with very a short homepage, which I know has been a problem in the past.

@jayhesselberth jayhesselberth merged commit 96e12f8 into r-lib:master May 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Bisaloo Bisaloo deleted the Bisaloo:sticky-css branch May 14, 2019

jeroen added a commit to ropensci/rotemplate that referenced this pull request May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.