Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display links when printing #1135

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@Bisaloo
Copy link
Contributor

commented Sep 3, 2019

fix #1134

Tested on latest firefox and chromium.

Bisaloo added 2 commits Sep 3, 2019
@Bisaloo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

@media print {
  code a[href]:after {
     content: initial;
  }
}

from https://stackoverflow.com/a/28090284 seems to work as well. Not sure which one should be preferred here.

@hadley hadley merged commit d7d8d51 into r-lib:master Sep 3, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 3dbc888...0595a2d
Details
codecov/project 84.41% remains the same compared to 3dbc888
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Thanks!

yiluheihei added a commit to yiluheihei/pkgdown that referenced this pull request Sep 3, 2019
Do not display links when printing (r-lib#1135)
* Do not display links when printing

* Update changelog
yiluheihei added a commit to yiluheihei/pkgdown that referenced this pull request Sep 3, 2019
Do not display links when printing (r-lib#1135)
* Do not display links when printing

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.