Fix BS5 navbar template to get navbar.type: dark to work with bslib 0.6+
#2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanho63
changed the title
navbar.type: dark to work with bslib 0.6+
|
I think we'd also need to bump the required bslib version to 0.6.1. This merge will break existing configs. |
|
@jayhesselberth I ran a test with this branch + bslib 0.5.1 on https://ffsimulator.ffverse.com with this GHA setup / run and I believe it works - the additional data-bs-theme attribute seems to have no effect under bslib 0.5, while under bslib 0.6+ the deprecated class seems to have no effect |
|
This feels like the right change to me. And I'm pretty sure @tanho63 is right that the additional attribute will have no effect with earlier versions of bslib/Bootstrap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2387
Bootstrap 5.3 docs suggest that
.navbar-darkis now deprecated in favour of using a data attributedata-bs-theme="dark", which seems to facilitate client-side light/dark mode switching.In contrast to the proposed fix within the issue, this PR adds the new attribute without removing the old class, so as to maintain backwards compat with bslib <0.6