New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build-ignore pkgdown infra during init #710

Merged
merged 8 commits into from Jun 6, 2018

Conversation

Projects
None yet
1 participant
@jayhesselberth
Collaborator

jayhesselberth commented Jun 2, 2018

pkgdown does not currently build-ignore the files it creates, causing a NOTE during R CMD CHECK.

init_site() now calls usethis::use_pkgdown() to add docs/ and _pkgdown.yml to .Rbuildignore.

Need to add news bullet once 1.1.0 is released.

Part of #709

Build-ignore pkgdown infra during init
pkgdown does not currently build-ignore the files it creates, causing a NOTE during R CMD CHECK.

`init_site()` now calls `usethis::use_pkgdown()` to add `docs/` and `_pkgdown.yml` to `.Rbuildignore`.

Part of #709

@jayhesselberth jayhesselberth referenced this pull request Jun 2, 2018

Closed

Documentation improvements #702

6 of 6 tasks complete

jayhesselberth added some commits Jun 4, 2018

@jayhesselberth jayhesselberth requested a review from hadley Jun 4, 2018

@jayhesselberth jayhesselberth merged commit 185193f into master Jun 6, 2018

4 checks passed

codecov/patch 100% of diff hit (target 85.23%)
Details
codecov/project 85.24% (+<.01%) compared to 9776461
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jayhesselberth jayhesselberth deleted the build-ignore branch Jun 7, 2018

hadley added a commit that referenced this pull request Nov 6, 2018

Don't call use_pkgdown in init_site()
Instead document what you need to do if you don't use it.

Reverts #710. Fixes #862. Closes #812.

hadley added a commit that referenced this pull request Nov 6, 2018

Don't call use_pkgdown in init_site() (#865)
Instead document what you need to do if you don't use it.

Reverts #710. Fixes #862. Closes #812.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment