New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `$restart()` #116

Closed
gaborcsardi opened this Issue May 21, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@gaborcsardi
Member

gaborcsardi commented May 21, 2018

Not very useful and it complicates things a lot.

gaborcsardi added a commit that referenced this issue May 22, 2018

gaborcsardi added a commit that referenced this issue May 22, 2018

@rickhelmus

This comment has been minimized.

rickhelmus commented Aug 21, 2018

[rant]I just spent the whole night figuring why AppVeyor suddenly failed with attempt to apply non-function. Maybe first do a .Deprecated() in the future?[/rant]

Sorry for that, still loving processx ;-) Anyway, I guess the new way is to simply re-create the object? I'm using restart() here and there to restart processes after a failure (e.g. a network timeout).

@gaborcsardi

This comment has been minimized.

Member

gaborcsardi commented Aug 21, 2018

@rickhelmus sorry. .Deprecated was not really an option because restart() was already not implemented for some of the new features. But yeah, I could have added a method that just throws an error that says the restart was removed.

Yeah, I would just write a function starts the process with the parameters you need, and if you need to restart it, just call the function again.

@rickhelmus

This comment has been minimized.

rickhelmus commented Aug 22, 2018

Thanks for the speedy reply!

Makes sense, probably would've done the same... so please ignore my previous rant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment