Fix capture on big endian systems#49
Merged
thomasp85 merged 2 commits intor-lib:masterfrom Oct 1, 2020
Merged
Conversation
Contributor
Author
|
Waiting to see if the build actually works (it's a bit slow...) |
Contributor
Author
|
Well, apparently it's a little bit better, as it's failing on |
R expects colours to be integers of ABGR, which on little-endian machines maps to singular bytes in RGBA order, but maps to ABGR order on bit-endian machines.
This seems to actually work, as __BIG_ENDIAN__ isn't defined on s390x. Possibly it needs another header, but it's easier to use a macro already in R.
QuLogic
force-pushed
the
capture-big-endian
branch
from
b1fe359 to
fb06330
Compare
Contributor
Author
|
Oops, that was a silly typo on my part. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R expects colours to be integers of ABGR, which on little-endian machines maps to singular bytes in RGBA order, but maps to ABGR order on bit-endian machines.
Fixes #48.