Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: formal argument "Ncpus" matched by multiple actual arguments #153

Closed
gaborcsardi opened this issue Sep 9, 2018 · 3 comments
Closed

Error: formal argument "Ncpus" matched by multiple actual arguments #153

gaborcsardi opened this issue Sep 9, 2018 · 3 comments

Comments

@gaborcsardi
Copy link
Contributor

@gaborcsardi gaborcsardi commented Sep 9, 2018

I get this for r-lib/rcmdcheck:

Error in utils::install.packages(pkgs = pkgs, lib = lib, repos = myrepos,  :
  formal argument "Ncpus" matched by multiple actual arguments

Maybe we could just remove the threads argument, it seems that ... is passed down, anyway?

@jimhester
Copy link
Member

@jimhester jimhester commented Sep 10, 2018

Yeah that sounds fine to me

@gaborcsardi
Copy link
Contributor Author

@gaborcsardi gaborcsardi commented Sep 10, 2018

This is a breaking change though, so maybe we should fix it without removing the threads argument.

gaborcsardi added a commit that referenced this issue Sep 10, 2018
If `Ncpus` was also specified, that led to an error.
Closes #153.
gaborcsardi added a commit that referenced this issue Sep 10, 2018
If `Ncpus` was also specified, that led to an error.
Closes #153.
gaborcsardi added a commit that referenced this issue Sep 10, 2018
If `Ncpus` was also specified, that led to an error.
Closes #153.
gaborcsardi added a commit that referenced this issue Sep 10, 2018
If `Ncpus` was also specified, that led to an error.
Closes #153.
gaborcsardi added a commit that referenced this issue Sep 10, 2018
If `Ncpus` was also specified, that led to an error.
Closes #153.
@jimhester
Copy link
Member

@jimhester jimhester commented Sep 10, 2018

I think some breaking changes are ok within reason, I am going to be releasing the remotes integrated devtools as 2.0.0 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants