Skip to content

/remotes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: formal argument "Ncpus" matched by multiple actual arguments #153

Closed
gaborcsardi opened this issue Sep 9, 2018 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gaborcsardi @jimhester
@gaborcsardi
Copy link
Member

commented Sep 9, 2018

I get this for r-lib/rcmdcheck:

Error in utils::install.packages(pkgs = pkgs, lib = lib, repos = myrepos,  :
  formal argument "Ncpus" matched by multiple actual arguments

Maybe we could just remove the threads argument, it seems that ... is passed down, anyway?
@jimhester

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 10, 2018

Yeah that sounds fine to me
@gaborcsardi

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Sep 10, 2018

This is a breaking change though, so maybe we should fix it without removing the threads argument.

gaborcsardi added a commit that referenced this issue Sep 10, 2018

@gaborcsardi
Remove `threads` arg of `install_deps()` 
If `Ncpus` was also specified, that led to an error.
Closes #153.
Loading status checks…
48eb813

@gaborcsardi gaborcsardi referenced this issue Sep 10, 2018

Merged

Remove `threads` arg of `install_deps()` #154

gaborcsardi added a commit that referenced this issue Sep 10, 2018

@gaborcsardi
Remove `threads` arg of `install_deps()` 
If `Ncpus` was also specified, that led to an error.
Closes #153.
Loading status checks…
f23b37b

gaborcsardi added a commit that referenced this issue Sep 10, 2018

@gaborcsardi
Remove `threads` arg of `install_deps()` 
If `Ncpus` was also specified, that led to an error.
Closes #153.
Loading status checks…
85e1601

gaborcsardi added a commit that referenced this issue Sep 10, 2018

@gaborcsardi
Remove `threads` arg of `install_deps()` 
If `Ncpus` was also specified, that led to an error.
Closes #153.
Loading status checks…
25ca7e1

@gaborcsardi gaborcsardi closed this in #154 Sep 10, 2018

gaborcsardi added a commit that referenced this issue Sep 10, 2018

@gaborcsardi
Remove `threads` arg of `install_deps()` (#154) 
If `Ncpus` was also specified, that led to an error.
Closes #153.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aaa1fd3
@jimhester

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 10, 2018

I think some breaking changes are ok within reason, I am going to be releasing the remotes integrated devtools as 2.0.0 anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.