Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_deps() does not work when upgrade=FALSE #218

Closed
heavywatal opened this issue Oct 22, 2018 · 3 comments
Closed

install_deps() does not work when upgrade=FALSE #218

heavywatal opened this issue Oct 22, 2018 · 3 comments

Comments

@heavywatal
Copy link

@heavywatal heavywatal commented Oct 22, 2018

install() seems to be broken in devtools 2.0. I guess it is attributed to remotes package. Here is a reprex:

git clone https://github.com/tidyverse/purrr.git
cd purrr/
R
remove.packages("tibble")
remotes::install_local(dependencies=TRUE, upgrade=FALSE)
# ERROR: dependency ‘tibble’ is not available for package ‘purrr’
remotes::install_deps(dependencies=TRUE, upgrade=FALSE)
## Nothing happens

Maybe update.package_deps() needs some fix:

packages = remotes::dev_package_deps()
print(packages)
# Needs update -----------------------------
# update(packages, upgrade = FALSE)
# 
#  package installed available is_cran remote
#  rlang   0.2.2     0.3.0     TRUE    CRAN
#  tibble  NA        1.4.2     TRUE    CRAN
remotes:::update.package_deps(packages, upgrade=FALSE)
## Nothing happens
remotes:::upgradable_packages(packages, upgrade=FALSE, quiet=FALSE)
## Nothing happens
remotes:::upgradable_packages(packages, upgrade=TRUE, quiet=FALSE)
# rlang  (0.2.2 -> 0.3.0) [CRAN]
# tibble (NA    -> 1.4.2) [CRAN]
@ankane
Copy link
Contributor

@ankane ankane commented Oct 23, 2018

fwiw, I'm seeing the same behavior with remotes::install_deps(upgrade=FALSE).

Remotes: 2.0.1
Platform: Mac

@ankane ankane mentioned this issue Oct 23, 2018
8 tasks
@jimhester jimhester closed this in 0227f7d Oct 23, 2018
@ankane
Copy link
Contributor

@ankane ankane commented Oct 23, 2018

Works great now, thanks @jimhester!

@ankane
Copy link
Contributor

@ankane ankane commented Oct 23, 2018

Spoke too soon :) Still seeing this with packages that use the Remotes: field.

Sample DESCRIPTION

Imports: dbx
Remotes: github::ankane/dbx

Works fine when the Remotes: line is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants