remotes::install_github() conflicts with custom _R_CHECK_FORCE_SUGGESTS_

[pat-s]

Gave me quite some headache to find the cause of this error.
We had an env var _R_CHECK_FORCE_SUGGESTS_ = 0 set in our project. This caused the error below. Maybe you can somehow handle this internally.

Probably caused by this commit.

remotes::install_github("ropenscilabs/tic@test")
Downloading GitHub repo ropenscilabs/tic@test
✔  checking for file ‘/tmp/RtmpYz0tm9/remotes3a993d916193/ropenscilabs-tic-de4d39a/DESCRIPTION’ ...
─  preparing ‘tic’:
✔  checking DESCRIPTION meta-information ...
─  checking for LF line-endings in source and make files and shell scripts
─  checking for empty or unneeded directories
─  building ‘tic_0.2.13.9010.tar.gz’
   
Error in if (should_error_for_warnings()) { : 
  missing value where TRUE/FALSE needed
> traceback()
8: force(code)
7: with_envvar(c(R_LIBS = lib, R_LIBS_USER = lib, R_LIBS_SITE = lib), 
       if (should_error_for_warnings()) {
           with_options(list(warn = 2), with_rprofile_user("options(warn = 2)", 
               i.p(...)))
       } else {
           i.p(...)
       })
6: safe_install_packages(pkgdir, repos = NULL, quiet = quiet, type = "source", 
       ...)
5: install(source, dependencies = dependencies, upgrade = upgrade, 
       force = force, quiet = quiet, build = build, build_opts = build_opts, 
       repos = repos, type = type, ...)
4: FUN(X[[i]], ...)
3: vapply(remotes, install_remote, ..., FUN.VALUE = character(1))
2: install_remotes(remotes, auth_token = auth_token, host = host, 
       dependencies = dependencies, upgrade = upgrade, force = force, 
       quiet = quiet, build = build, build_opts = build_opts, repos = repos, 
       type = type, ...)
1: remotes::install_github("ropenscilabs/tic@test")

[jimhester]

No, _R_CHECK_FORCE_SUGGESTS_=0 is not valid.

[pat-s]

Oh, sorry for this then. Didn't know that as I didn't add it.

[jimhester]

Ok so this is not actually true, tools:::config_val_to_logical (which is what R CMD check uses internally) does explicitly allow a '0' argument.

I guess we can include the same logic in remotes.

[jeroen]

+1 also running into this on travis. I think setting env vars to 0 or 1 is actually quite common.