Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remotes::install_github() conflicts with custom _R_CHECK_FORCE_SUGGESTS_ #238

Closed
pat-s opened this issue Nov 3, 2018 · 4 comments
Closed

Comments

@pat-s
Copy link

pat-s commented Nov 3, 2018

Gave me quite some headache to find the cause of this error.
We had an env var _R_CHECK_FORCE_SUGGESTS_ = 0 set in our project. This caused the error below. Maybe you can somehow handle this internally.

Probably caused by this commit.

remotes::install_github("ropenscilabs/tic@test")
Downloading GitHub repo ropenscilabs/tic@testchecking for file/tmp/RtmpYz0tm9/remotes3a993d916193/ropenscilabs-tic-de4d39a/DESCRIPTION...preparingtic:checking DESCRIPTION meta-information ...checking for LF line-endings in source and make files and shell scriptschecking for empty or unneeded directoriesbuildingtic_0.2.13.9010.tar.gzError in if (should_error_for_warnings()) { : 
  missing value where TRUE/FALSE needed
> traceback()
8: force(code)
7: with_envvar(c(R_LIBS = lib, R_LIBS_USER = lib, R_LIBS_SITE = lib), 
       if (should_error_for_warnings()) {
           with_options(list(warn = 2), with_rprofile_user("options(warn = 2)", 
               i.p(...)))
       } else {
           i.p(...)
       })
6: safe_install_packages(pkgdir, repos = NULL, quiet = quiet, type = "source", 
       ...)
5: install(source, dependencies = dependencies, upgrade = upgrade, 
       force = force, quiet = quiet, build = build, build_opts = build_opts, 
       repos = repos, type = type, ...)
4: FUN(X[[i]], ...)
3: vapply(remotes, install_remote, ..., FUN.VALUE = character(1))
2: install_remotes(remotes, auth_token = auth_token, host = host, 
       dependencies = dependencies, upgrade = upgrade, force = force, 
       quiet = quiet, build = build, build_opts = build_opts, repos = repos, 
       type = type, ...)
1: remotes::install_github("ropenscilabs/tic@test")
@jimhester
Copy link
Member

jimhester commented Nov 5, 2018

No, _R_CHECK_FORCE_SUGGESTS_=0 is not valid.

@pat-s
Copy link
Author

pat-s commented Nov 5, 2018

Oh, sorry for this then. Didn't know that as I didn't add it.

@jimhester
Copy link
Member

jimhester commented Nov 5, 2018

Ok so this is not actually true, tools:::config_val_to_logical (which is what R CMD check uses internally) does explicitly allow a '0' argument.

I guess we can include the same logic in remotes.

@jimhester jimhester reopened this Nov 5, 2018
@jeroen
Copy link
Member

jeroen commented Jan 11, 2019

+1 also running into this on travis. I think setting env vars to 0 or 1 is actually quite common.

screen shot 2019-01-11 at 1 44 47 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants