Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enters infinite loop on mutual depends in Remotes #31

Closed
cboettig opened this issue Jun 14, 2016 · 5 comments
Closed

enters infinite loop on mutual depends in Remotes #31

cboettig opened this issue Jun 14, 2016 · 5 comments

Comments

@cboettig
Copy link

@cboettig cboettig commented Jun 14, 2016

Looks like this issue was fixed in the dev version of dplyr, but still impacts this package. e.g. remotes::install_github("hadley/dplyr") fails due to recursive dependency between dplyr and dtplyr,
tidyverse/dplyr#1904.

Thanks!

@gaborcsardi
Copy link
Contributor

@gaborcsardi gaborcsardi commented Jun 15, 2016

Indeed, thanks!

@gaborcsardi
Copy link
Contributor

@gaborcsardi gaborcsardi commented Jul 4, 2016

I don't think this is fixed in devtools, actually. The "fix" was that they removed the actual circular dependency. (Which is the correct fix.)

Still, it would be nice to detect the circular dependencies, but I don't think that this is very important.

@jimhester
Copy link
Member

@jimhester jimhester commented Apr 5, 2017

This is handled in devtools, as part of r-lib/devtools#1067, in particular r-lib/devtools@a3dcdf8

@gaborcsardi
Copy link
Contributor

@gaborcsardi gaborcsardi commented Apr 15, 2017

Yes, this is actually an issue, currently. Only if a package in Remotes is a soft dependency somewhere in the chain, though, because hard dependencies cannot be circular.

@gaborcsardi
Copy link
Contributor

@gaborcsardi gaborcsardi commented Apr 15, 2017

Thanks! I finally understood that this can be a problem, and fixed it, the same way as in devtools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants