Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_github_repo does not allow trailing slash in subdirectory #54

Closed
richfitz opened this issue Feb 20, 2017 · 1 comment
Closed

parse_github_repo does not allow trailing slash in subdirectory #54

richfitz opened this issue Feb 20, 2017 · 1 comment

Comments

@richfitz
Copy link

@richfitz richfitz commented Feb 20, 2017

A trailing slash in a subdirectory specification causes an error in parse_github_repo

> remotes::parse_github_repo_spec("foo/bar/baz/")
Error in remotes::parse_github_repo_spec("foo/bar/baz/") : 
  Invalid git repo: foo/bar/baz/
> remotes::parse_github_repo_spec("foo/bar/baz")
$username
[1] "foo"

$repo
[1] "bar"

$subdir
[1] "baz"

I think that the these should both point at the same place

@richfitz
Copy link
Author

@richfitz richfitz commented Mar 1, 2017

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant