Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Export github_remote and other remote functions? #56

Closed
muschellij2 opened this issue Mar 9, 2017 · 2 comments
Closed

ENH: Export github_remote and other remote functions? #56

muschellij2 opened this issue Mar 9, 2017 · 2 comments

Comments

@muschellij2
Copy link
Contributor

muschellij2 commented Mar 9, 2017

Would it be possible to export github_remote? This is the one I'm interested in, but other remotes classes may be relevant. I wanted to use this useful function for a package, but have to use nonexport :::, resulting in warning/note.

I know that it may be unstable (hence the non-export), but I think it may be useful to others to use.
@muschellij2
Copy link
Contributor Author

muschellij2 commented Mar 9, 2017

I realize that I can manufacture similar functionality that I need with parse_github_repo_spec, so I don't know if this is necessary.

@gaborcsardi
Copy link
Contributor

gaborcsardi commented Mar 10, 2017

I would prefer not to export it, the package internals will likely to be rewritten soon. Let me know if this is a blocker for you.

@zappingseb zappingseb mentioned this issue Mar 18, 2020
Closed
jimhester added a commit that referenced this issue Jul 15, 2020
@jimhester
Export internal methods to package authors can extend them
ffcfd1b 
Fixes #56
Fixes #485
Fixes #509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaborcsardi @muschellij2