Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept common URLs as repo spec in parse_github_repo_spec(); closes #90 #109

Merged
merged 2 commits into from Sep 14, 2017
Merged

Accept common URLs as repo spec in parse_github_repo_spec(); closes #90 #109

merged 2 commits into from Sep 14, 2017

Conversation

@jennybc
Copy link
Member

@jennybc jennybc commented Sep 14, 2017

No description provided.

@gaborcsardi
Copy link
Contributor

@gaborcsardi gaborcsardi commented Sep 14, 2017

Thanks! Looks pretty good! I have wanted this for a long time!

Loading

NEWS.md Outdated
@@ -1,6 +1,9 @@

# 1.1.0

* Accept browser, HTTPS, or SSH URL in GitHub repo specification,
Copy link
Contributor

@gaborcsardi gaborcsardi Sep 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAn you please move this up to a new section. Version 1.1.0.9000? Thanks!

Loading

Copy link
Contributor

@gaborcsardi gaborcsardi Sep 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.1.0 is actually the current version....

Loading

Copy link
Member Author

@jennybc jennybc Sep 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done!

Loading

@gaborcsardi
Copy link
Contributor

@gaborcsardi gaborcsardi commented Sep 14, 2017

Perfect. Thanks much again!

Loading

@gaborcsardi gaborcsardi merged commit 3f4ca1e into r-lib:master Sep 14, 2017
0 of 2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants