Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX: Invalid R_LIBS* paths on Windows #253

Merged
merged 1 commit into from Nov 17, 2018

Conversation

HenrikBengtsson
Copy link
Contributor

@HenrikBengtsson HenrikBengtsson commented Nov 16, 2018

safe_install_packages() used a colon as a path separator also on Windows, resulting in invalid R_LIBS* values.

For example, with startup::startup() in ~/.Rprofile, which checks for this, using remotes::install_*() would produce warnings about this:

Warning messages:
1: Environment variable 'R_LIBS_SITE' specifies a non-existing folder 'C:/Users/hb/Documents/R/win-library/3.5:C:/Program Files/R/R-3.5.1/library' (expands to 'C:\Users\hb\Documents\R\win-library\3.5:C:\Program Files\R\R-3.5.1\library') which R ignores and therefore are not used in .libPaths(). To create this folder, call dir.create("C:/Users/hb/Documents/R/win-library/3.5:C:/Program Files/R/R-3.5.1/library", recursive = TRUE) 
2: Environment variable 'R_LIBS_USER' specifies a non-existing folder 'C:/Users/hb/Documents/R/win-library/3.5:C:/Program Files/R/R-3.5.1/library' (expands to 'C:\Users\hb\Documents\R\win-library\3.5:C:\Program Files\R\R-3.5.1\library') which R ignores and therefore are not used in .libPaths(). To create this folder, call dir.create("C:/Users/hb/Documents/R/win-library/3.5:C:/Program Files/R/R-3.5.1/library", recursive = TRUE) 

@gaborcsardi gaborcsardi merged commit 0e17379 into r-lib:master Nov 17, 2018
4 checks passed
@gaborcsardi
Copy link
Contributor

gaborcsardi commented Nov 17, 2018

Thanks!

gaborcsardi added a commit that referenced this issue Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants