Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL-encode GitHub reference #38

Merged
merged 3 commits into from Nov 11, 2016

Conversation

Projects
None yet
3 participants
@krlmlr
Copy link
Member

commented Sep 15, 2016

in install_github().

Use case:

install_github("krlmlr/ranger/ranger-r-package/ranger@b-#118-dimnames")

(The dash in #118 is the offender.)

Also affects devtools, CC @jimhester @hadley.

@codecov-io

This comment has been minimized.

Copy link

commented Sep 15, 2016

Current coverage is 93.78% (diff: 75.00%)

Merging #38 into master will decrease coverage by 0.08%

@@             master        #38   diff @@
==========================================
  Files            23         23          
  Lines          1028       1030     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            965        966     +1   
- Misses           63         64     +1   
  Partials          0          0          

Powered by Codecov. Last update 28c820e...9bb69f1

@krlmlr

This comment has been minimized.

Copy link
Member Author

commented Nov 11, 2016

Could you please review?

@gaborcsardi

This comment has been minimized.

Copy link
Member

commented Nov 11, 2016

Thanks, looks good, but you don't seem to use vlapply, so maybe we can remove that for now.

@gaborcsardi

This comment has been minimized.

Copy link
Member

commented Nov 11, 2016

Thanks!

@gaborcsardi gaborcsardi merged commit f5d819a into r-lib:master Nov 11, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@krlmlr krlmlr deleted the krlmlr:b-dash branch Jul 8, 2017

@krlmlr

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2017

@gaborcsardi: Do you plan a CRAN release anytime soon? I tend to use the dash in branch names...

@gaborcsardi

This comment has been minimized.

Copy link
Member

commented Jul 9, 2017

@krlmlr I don't mind, but it depends on crancache now. :(

@krlmlr

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2017

I learned a lesson: Release to CRAN before adding a dependency :/

@gaborcsardi

This comment has been minimized.

Copy link
Member

commented Jul 9, 2017

I think that's a good lesson, but does not help this situation.

It is actually trivial to temporarily remove the dependency, let me do it quickly.

@gaborcsardi

This comment has been minimized.

Copy link
Member

commented Jul 9, 2017

Just submitted to CRAN.

@krlmlr

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2017

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.