Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Change default download method if needed #46
This PR follows a discussion to resolve #45 . See issue post.
Based on some research about downloads method in R, I decided to modify
We could have done differently
Hope it is not too bad and I did not forgot anything
Current coverage is 93.90% (diff: 100%)
@@ master #46 diff @@ ========================================== Files 23 23 Lines 1030 1034 +4 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 967 971 +4 Misses 63 63 Partials 0 0
Done. Just a precision : If "libcurl" is not available on non windows platform, method is set to "auto".
Now, not sure what I should do. If you have some advices...
I look forward to collaborate more to learn more on the way to go with PR and projects collaborations
Dec 1, 2016
I just noticed that I did not modified
So, just for you to know, PR is merged and it is working now on windows but
is not working without proxy configuration on windows as it has not been updated with the new version of
Good point. I'll update the script, and the
I should probably decide if I want
So, just a note, that I'll change the default method to libcurl, whenever it is available, because it is not possible to send custom headers, and thus do a basic HTTP auth, with wininet.
You'll be still able to use wininet, if you set