Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make install_*() abortable #489

Closed
wants to merge 1 commit into from
Closed

Make install_*() abortable #489

wants to merge 1 commit into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 30, 2020

because it's notoriously difficult to abort otherwise, at least in RStudio.

I'm using devmode, CRAN packages go to the "stable" library, GitHub packages to the "dev" one. If an update is required, I never want to upgrade packages from CRAN (because they would land in "dev"), instead I want to upgrade "stable" manually before proceeding.

@jimhester
Copy link
Member

jimhester commented Mar 30, 2020

This seems like a bug in RStudio, on the terminal you can send an interrupt to abort it, but RStudio does not seem to support this when the R process is waiting for input.

@krlmlr
Copy link
Member Author

krlmlr commented Mar 30, 2020

If the mountain won't come to the prophet...

@jimhester jimhester closed this in 7720273 Mar 30, 2020
@jimhester
Copy link
Member

jimhester commented Mar 30, 2020

Turns out RStudio supports interrupting using readline(), but not readLines(), so we can just switch to the former to get the same interrupt behavior in RStudio as on the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants