Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WORKAROUND: unzip may be set to "" on some Linux systems #57

Merged
merged 1 commit into from Apr 8, 2017
Merged

WORKAROUND: unzip may be set to "" on some Linux systems #57

merged 1 commit into from Apr 8, 2017

Conversation

@HenrikBengtsson
Copy link
Contributor

@HenrikBengtsson HenrikBengtsson commented Apr 8, 2017

unzip may be set to "" on some Linux systems, which causes remotes::install_remote() to generate an obscure error that is a bit tedious to troubleshoot:

Error in system_check(unzip, args) :
  Command  failed sh: : command not found

Since "internal" unzip always, work this patch makes sure that is
used also when unzip is "".

See https://bugs.r-project.org/bugzilla/show_bug.cgi?id=17255 for
more details on why unzip may become "".

PS. Yes, one could force options(unzip = "internal") on such systems, and ideally utils:::.onLoad() should do that, but until then this is user friendly patch.

remotes::install_remote() to generate an obscure error message:

Error in system_check(unzip, args) :
  Command  failed sh: : command not found

Since "internal" unzip always, work this patch makes sure that is
used also when unzip is "".

See https://bugs.r-project.org/bugzilla/show_bug.cgi?id=17255 for
more details on why unzip may become "".
@gaborcsardi
Copy link
Contributor

@gaborcsardi gaborcsardi commented Apr 8, 2017

Thanks!

Loading

@gaborcsardi gaborcsardi merged commit ba7a8bc into r-lib:master Apr 8, 2017
1 check failed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants