Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_integerish() and large numbers #578

Closed
krlmlr opened this issue Aug 19, 2018 · 1 comment
Closed

is_integerish() and large numbers #578

krlmlr opened this issue Aug 19, 2018 · 1 comment
Labels

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Aug 19, 2018

rlang::is_integerish(1e10)
#> Warning in rlang::is_integerish(1e+10): NAs introduced by coercion to
#> integer range
#> [1] NA

Created on 2018-08-20 by the reprex package (v0.2.0).

Do we need to use trunc() instead of as.integer() ?

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Aug 19, 2018

Or do we need to add a range check?

@lionel- lionel- added the vector label Sep 3, 2018
lionel- added a commit to lionel-/rlang that referenced this issue Oct 3, 2018
lionel- added a commit to lionel-/rlang that referenced this issue Oct 3, 2018
lionel- added a commit to lionel-/rlang that referenced this issue Oct 3, 2018
lionel- added a commit to lionel-/rlang that referenced this issue Oct 5, 2018
@lionel- lionel- closed this in #642 Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants