Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for weak references #787

Merged
merged 6 commits into from Jun 13, 2019
Merged

Add support for weak references #787

merged 6 commits into from Jun 13, 2019

Conversation

@wch
Copy link
Member

@wch wch commented Jun 12, 2019

This PR adds an R interface for weak references. I tried to use the conventions in rlang, but please let me know if things should be done differently.

I'm not sure if this is correct, but I used @keywords experimental.

@wch wch requested review from hadley and lionel- Jun 12, 2019
Copy link
Member

@lionel- lionel- left a comment

Looks good! About the naming, I think wref_value() and wref_key() would be more in line with the general naming in rlang.

R/weakref.R Outdated Show resolved Hide resolved
R/weakref.R Outdated Show resolved Hide resolved
R/weakref.R Outdated Show resolved Hide resolved
R/weakref.R Outdated Show resolved Hide resolved
R/weakref.R Outdated Show resolved Hide resolved
R/weakref.R Outdated Show resolved Hide resolved
R/weakref.R Outdated Show resolved Hide resolved
R/weakref.R Outdated Show resolved Hide resolved
NAMESPACE Show resolved Hide resolved
@lionel- lionel- merged commit 35b11ca into r-lib:master Jun 13, 2019
1 check passed
@lionel-
Copy link
Member

@lionel- lionel- commented Jun 13, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants