Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra { around inherited ifelse tags #1062

Closed
akersting opened this issue Mar 17, 2020 · 1 comment · Fixed by #1201
Closed

Extra { around inherited ifelse tags #1062

akersting opened this issue Mar 17, 2020 · 1 comment · Fixed by #1201
Labels
bug an unexpected problem or unintended behavior inherit 👨‍👩‍👧‍👦
Milestone
v7.1.3

Comments

@akersting
Copy link
Contributor

Using @inheritParams produces "bad markup" if the Rd inherited from contains \ifelse as e.g. the case for parallel::mclapply.

This is very similar to #778 (fixed in e1d3930). Also here extra {} are added. Hence, adding "\\ifelse" to the vector TWOARG of as_character_rd should fix the issue.
@hadley hadley added bug an unexpected problem or unintended behavior rd ✍️ labels May 1, 2020
@hadley
Copy link
Member

hadley commented May 1, 2020

Would you be interested in contributing a PR?

akersting added a commit to akersting/roxygen2 that referenced this issue Feb 17, 2021
@akersting
add failing test for r-lib#1062
3f0b4f7
akersting added a commit to akersting/roxygen2 that referenced this issue Feb 17, 2021
@akersting
fix r-lib#1062: Extra { around inherited ifelse tags
910f9e3
akersting added a commit to akersting/roxygen2 that referenced this issue Feb 17, 2021
@akersting
add item to NEWS for fix of r-lib#1062
3b17925
@akersting akersting mentioned this issue Feb 17, 2021
Merged
hadley added a commit to akersting/roxygen2 that referenced this issue Apr 16, 2021
@hadley
Merged origin/master into akersting-fix/r-lib#1062
59fd314
@hadley hadley added this to the v7.1.3 milestone Mar 29, 2022
@hadley hadley mentioned this issue Mar 29, 2022
Closed
@hadley hadley changed the title (fix included) Extra { around inherited ifelse tags Extra { around inherited ifelse tags Mar 29, 2022
hadley added a commit to akersting/roxygen2 that referenced this issue Mar 29, 2022
@hadley
Merged origin/main into akersting-fix/r-lib#1062
7058b36
hadley pushed a commit that referenced this issue Mar 29, 2022
@akersting
Strip extra { around inherited \ifelse (#1201)
2f5079a 
Fixes #1062
@hadley hadley mentioned this issue Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior inherit 👨‍👩‍👧‍👦
Projects
None yet
Milestone
v7.1.3
Development

Successfully merging a pull request may close this issue.

Strip extra { around inherited \ifelse akersting/roxygen2
2 participants
@hadley @akersting