Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate @s3method #198

Closed
hadley opened this issue Feb 18, 2014 · 5 comments
Closed

Deprecate @s3method #198

hadley opened this issue Feb 18, 2014 · 5 comments

Comments

@hadley
Copy link
Member

@hadley hadley commented Feb 18, 2014

Since it's no longer needed.

@hadley hadley closed this in 9d8ad5c Feb 18, 2014
@joshuaulrich
Copy link

@joshuaulrich joshuaulrich commented Oct 28, 2015

Please note that you have removed the functionality, not deprecated it. Please deprecate before removing so users aren't forced to change their code to update to the latest package.

@hadley
Copy link
Member Author

@hadley hadley commented Oct 28, 2015

Yes, I deprecated it over 18 months ago. And now it's gone.

@joshuaulrich
Copy link

@joshuaulrich joshuaulrich commented Oct 28, 2015

Where is the commit that deprecated it? I see a commit that removed it, and no releases since then.

@hadley
Copy link
Member Author

@hadley hadley commented Oct 28, 2015

The commit that is linked above.

@joshuaulrich
Copy link

@joshuaulrich joshuaulrich commented Oct 28, 2015

Ugh, I'm dense, sorry. I didn't notice that ns_S3method is throwing a warning and then still calling export_s3_method. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants