Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in call to tag_warning for noRd #418

Closed
thomasp85 opened this issue Oct 30, 2015 · 0 comments
Closed

Bug in call to tag_warning for noRd #418

thomasp85 opened this issue Oct 30, 2015 · 0 comments

Comments

@thomasp85
Copy link
Member

@thomasp85 thomasp85 commented Oct 30, 2015

Parsing @nord results in a value of "\n". This raises a warning about the tag not supporting parameters. Worse the resulting tag_warning contains a bug:

> tags$noRd
function (x) 
{
    if (x$val != "") {
        tag_warning("has no parameters")  ### Should be tag_warning(x, "has no parameters")
    }
    else {
        x
    }
}
<environment: namespace:roxygen2>

Both this and #417 seems to be related to how tags are being parsed. Probably there are a problem with including "\n" for the last line in the tag..? If the inclusion is intentional then the tag parsing should be modified to take this into account.

Most tags include a test for x$val == "". These will never fire as tags will always contain "\n"

thomasp85 added a commit to thomasp85/roxygen that referenced this issue Oct 30, 2015
@hadley hadley closed this Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants