Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example tag reads example file in native encoding #564

Closed
krlmlr opened this issue Jan 25, 2017 · 0 comments
Closed

example tag reads example file in native encoding #564

krlmlr opened this issue Jan 25, 2017 · 0 comments

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 25, 2017

in topic_add_examples(). Should be package encoding instead, for cross-platform compatibility.

hadley added a commit that referenced this issue Aug 17, 2017
* Helpers read_lines and write_lines do the right thing
* readLines() and writeLines() through errors to prevent accidental re-use in the future
* Warn if package encoding is not utf-8

Fixes #564. Fixes #592
@hadley hadley added the wip label Aug 17, 2017
hadley added a commit that referenced this issue Aug 18, 2017
* Helpers read_lines and write_lines do the right thing
* readLines() and writeLines() through errors to prevent accidental re-use in the future
* Warn if package encoding is not utf-8

Fixes #564. Fixes #592
hadley added a commit that referenced this issue Aug 23, 2017
* Helpers read_lines and write_lines do the right thing
* readLines() and writeLines() through errors to prevent accidental re-use in the future
* Warn if package encoding is not utf-8

Fixes #564. Fixes #592
@hadley hadley closed this in #649 Aug 23, 2017
hadley added a commit that referenced this issue Aug 23, 2017
* Helpers read_lines and write_lines do the right thing
* readLines() and writeLines() through errors to prevent accidental re-use in the future
* Warn if package encoding is not utf-8

Fixes #564. Fixes #592. Thanks to @jimhester for actually figuring out how to make this work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants