Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of load_code in roxygenize() #784

Closed
jennybc opened this issue Aug 20, 2018 · 10 comments
Closed

Behaviour of load_code in roxygenize() #784

jennybc opened this issue Aug 20, 2018 · 10 comments

Comments

@jennybc
Copy link
Member

@jennybc jennybc commented Aug 20, 2018

This devtools discussion around updating devtools::document() in light of roxygen v6.1.0 needs to continue here:

r-lib/devtools#1849

Excerpt to remind what this is about:

... the helpers = FALSE behaviour (in the sense of load_all(pkg$path, helpers = FALSE)) has been lost. Is that worth taking a stand on?

Two additional points raised by @jimhester in the other thread:

Maybe we should be calling pkgload::load_all(helpers = FALSE) in roxygen2 and maybe export_all = FALSE to more closely mimic a normal package namespace? I am not sure what roxygen2 assumes in regards to exports.

Also potentially recompile = FALSE, which would be a way to fix #771, but maybe would cause other issues if the dll was not built.

@spennihana

This comment has been hidden.

@gaborcsardi

This comment has been hidden.

@hadley

This comment has been hidden.

@gaborcsardi

This comment has been hidden.

@hadley

This comment has been hidden.

@spennihana

This comment has been hidden.

@hadley

This comment has been hidden.

@hadley
Copy link
Member

@hadley hadley commented Oct 23, 2018

Unfortunately there's no way to completely suppress compilation in pkgload::load_all()recompile = FALSE is already the default, but what we actually need is compile = FALSE. I'll implement that in pkgload and then once that's on CRAN (hopefully later this week), I'll do pkgload::load_all(compile = FALSE, helpers = FALSE), which should resolve the worst of the problems related to this change.

jimhester added a commit to r-lib/pkgload that referenced this issue Oct 29, 2018
This allows you to optionally disable re-compilation entirely, or force a full recompile.

Needed for r-lib/roxygen2#784
@hadley hadley closed this in 9adcc8e Nov 2, 2018
@hadley
Copy link
Member

@hadley hadley commented Nov 2, 2018

Should be better now. Can someone else confirm that this fixes the problem before I push to CRAN?

@hadley hadley mentioned this issue Nov 2, 2018
12 tasks
@hadley
Copy link
Member

@hadley hadley commented Nov 6, 2018

I need to release today to fix issues with CRAN R cmd check and I'll hope silence indicates no major problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants