Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending roxygen2 vignette #882

Closed
hadley opened this issue Jul 21, 2019 · 8 comments
Closed

Extending roxygen2 vignette #882

hadley opened this issue Jul 21, 2019 · 8 comments

Comments

@hadley
Copy link
Member

@hadley hadley commented Jul 21, 2019

Document how to create your own tag, or your own roclet.

@mikldk
Copy link
Contributor

@mikldk mikldk commented Aug 10, 2019

I might be able to give this a try. Or is anybody else working on it now?

@hadley
Copy link
Member Author

@hadley hadley commented Aug 10, 2019

That’d be great! I’m not aware of anyone else working on it.

@mikldk
Copy link
Contributor

@mikldk mikldk commented Aug 11, 2019

Do you have a specific example of a tag/roclet in mind that would make a good example?

@hadley
Copy link
Member Author

@hadley hadley commented Aug 12, 2019

I don't; my sense would be that it would be best to construct something simple, specifically for teaching.

@mikldk
Copy link
Contributor

@mikldk mikldk commented Aug 23, 2019

@hadley I made a suggestion. See here. Not sure what's easiest: to just view my commit or to create a PR? I just didn't think it was worth a PR before you had a look and I heard your thoughts on the examples (probably still a lot of work before a PR is relevant). Let me know what you think; both about the examples and about how it's easiest for you to view it.

@hadley
Copy link
Member Author

@hadley hadley commented Sep 17, 2019

@mikldk sorry I missed this — that looks like a great start, and I think it's worth turning into a PR. I think it's useful enough to merge with a minimum of work, and then we can continue to build it out over time. Thanks for your help!

@mikldk
Copy link
Contributor

@mikldk mikldk commented Sep 18, 2019

@hadley no worries. I have now created the PR. Thanks for all yours!

@hadley hadley closed this in 735f645 Sep 18, 2019
@mamueller
Copy link

@mamueller mamueller commented Oct 10, 2019

Thanks a lot for addressing this issue. (I was the person who asked for it).
I found the vignette already helpful.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants