Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherited link is not qualified with namespace #979

Closed
lionel- opened this issue Nov 19, 2019 · 1 comment · Fixed by #980
Labels
Milestone

Comments

@lionel-
Copy link
Member

@lionel- lionel- commented Nov 19, 2019

With

#' @inheritParams vctrs::vec_cast

R CMD check produces this warning:

❯ checking Rd cross-references ... WARNING
  Missing link or links in documentation object 'vctrs.Rd':
    'stop_incompatible_type'
  See section 'Cross-references' in the 'Writing R Extensions' manual.

Because the inherited link contains a link that isn't namespace-qualified:

\item{x_arg}{Argument names for \code{x} and \code{y}. These are used
in error messages to inform the user about the locations of
incompatible types (see \code{\link[=stop_incompatible_type]{stop_incompatible_type()}}).}
lionel- added a commit to lionel-/sf that referenced this issue Nov 19, 2019
lionel- added a commit to lionel-/sf that referenced this issue Nov 19, 2019
lionel- added a commit to lionel-/sf that referenced this issue Nov 20, 2019
@hadley

This comment has been minimized.

Copy link
Member

@hadley hadley commented Nov 20, 2019

Minimal reprex:

rd <- roxygen2:::parse_rd("\\link[=stop_incompatible_type]{stop_incompatible_type()}")
roxygen2:::tweak_links(rd, "vctrs")
#> \link[=stop_incompatible_type]{stop_incompatible_type()}

Created on 2019-11-20 by the reprex package (v0.3.0)

@hadley hadley added the wip label Nov 20, 2019
@hadley hadley added this to the v7.0.1 milestone Nov 20, 2019
hadley added a commit that referenced this issue Nov 20, 2019
@hadley hadley closed this in #980 Nov 21, 2019
hadley added a commit that referenced this issue Nov 21, 2019
Fixes #979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.