.Rd files are forcibly rewritten with LF ending on Windows

[krlmlr]

despite of what's announced in the NEWS and in #841.

To reproduce:

• Clone any package on Windows
• Run unix2dos man/*.Rd
• Run devtools::document()

I believe this is because write_if_different() already receives character strings with embedded newlines, and write_lines() doesn't convert them to the detected newlines.

[hadley]

@jimhester can you please take a look?

[kent37]

This is really annoying. For a project created on Windows, with .Rd files created by roxygen2, after updating to roxygen2 7.0.2 and running CMD check, all the .Rd files have new line endings.

[hadley]

@krlmlr could you please try out #1003 and see if it works for you?

[krlmlr]

Works for me, but produces bogus Writing xxx.Rd messages. Would you like me to look into removing these?

[sz-cgt]

Just ran devtools::install_github("r-lib/roxygen2") and generated documentation on a Windows only project.

Still seeing \n instead of \r\n in the generared .Rd files

Before:

$ head -2 man/client.Rd | od -c
0000000   %       G   e   n   e   r   a   t   e   d       b   y       r
0000020   o   x   y   g   e   n   2   :       d   o       n   o   t
0000040   e   d   i   t       b   y       h   a   n   d  \r  \n   %
0000060   P   l   e   a   s   e       e   d   i   t       d   o   c   u
0000100   m   e   n   t   a   t   i   o   n       i   n       R   /   R
0000120   6   -   c   l   i   e   n   t   .   R  \r  \n

After devtools::document(roclets = c('rd', 'collate', 'namespace', 'vignette'))

$ head -2 man/client.Rd | od -c
0000000   %       G   e   n   e   r   a   t   e   d       b   y       r
0000020   o   x   y   g   e   n   2   :       d   o       n   o   t
0000040   e   d   i   t       b   y       h   a   n   d  \n   %       P
0000060   l   e   a   s   e       e   d   i   t       d   o   c   u   m
0000100   e   n   t   a   t   i   o   n       i   n       R   /   R   6
0000120   -   c   l   i   e   n   t   .   R  \n

[hadley]

@sz-cgt you'll need to install from the PR: devtools::install_github("r-lib/roxygen2#1003")

[sz-cgt]

Oops. Thanks. The PR works for me