Allow restricting image formats #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently opt in. If you set `restrict_image_formats` to `TRUE`, then SVG images are HTML-only and PDF images are PDF-only. Other file types are not restricted. We could try to make it opt out, because SVGs do not work in LaTeX and PDFs most of the time do not work in HTML. If it is opt in, then we don't necessarily need a NEWS item to try this out, but if it ends up being opt out, then we do and we also need to document it, Closes #1398.
gaborcsardi
force-pushed
the
feature/image-formats
branch
from
1ef6743
to
c4aa67e
Compare
hadley
approved these changes
Jul 11, 2022
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently opt in. If you set
restrict_image_formatsto
TRUE, then SVG images are HTML-only and PDF images arePDF-only. Other file types are not restricted.
We could try to make it opt out, because SVGs do not work in
LaTeX and PDFs most of the time do not work in HTML.
If it is opt in, then we don't necessarily need a NEWS item
to try this out, but if it ends up being opt out, then we
do and we also need to document it,
Closes #1398.