Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use explicit qualification for methods::is #305

Merged
merged 3 commits into from Nov 18, 2014
Merged

use explicit qualification for methods::is #305

merged 3 commits into from Nov 18, 2014

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 18, 2014

so that it works when methods is not loaded (Rscript)

Kirill Müller added 2 commits Nov 18, 2014
so that it works when methods is not loaded (Rscript)
@@ -57,8 +57,9 @@ standardise_obj <- function(name, value, env = emptyenv(), block = list()) {
}
}

#' @import methods
Copy link
Member

@hadley hadley Nov 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Member Author

@krlmlr krlmlr Nov 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, sorry -- already removed it.

hadley added a commit that referenced this issue Nov 18, 2014
use explicit qualification for methods::is
@hadley hadley merged commit 824bf13 into r-lib:master Nov 18, 2014
1 check passed
@krlmlr krlmlr deleted the import-methods branch Nov 19, 2014
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Nov 19, 2014

I wonder if there's a way to make R CMD check or devtools::check warn for these annoyances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants