Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep whitespace in Authors@R field #330

Merged
merged 3 commits into from Mar 30, 2015
Merged

Conversation

@jranke
Copy link
Contributor

@jranke jranke commented Mar 29, 2015

As the structure of the Authors@R field is potentially a bit more
complex than that of the other fields, this commmit leads to whitespace
being preserved when reading in the Authors@R field.

As the structure of the Authors@R field is potentially a bit more
complex than that of the other fields, this commmit leads to whitespace
being preserved when reading in the Authors@R field.
@hadley
Copy link
Member

@hadley hadley commented Mar 30, 2015

Could you add a test for this? It's a bit tricky because you might also need to preserve on output too - or maybe roxygen should be preserving whitespace for all inputs?

jranke added 2 commits Mar 30, 2015
Keeping whitespace on reading the Authors@R field and not doing any
wrapping actually involves not to apply the function
wrap_field_if_necessary().
paste("LongPoem:", poem)
)
}
poem <- paste(sample(letters, 1000, TRUE), collapse = "")
Copy link
Contributor Author

@jranke jranke Mar 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the "Infinity threshold turns off wrapping" test just fixes the formatting to match the other tests.

@jranke
Copy link
Contributor Author

@jranke jranke commented Mar 30, 2015

OK, so a test has been added to the pull request that checks that the
formatting of the Authors@R field is preserved (which it wasn't in my original
commit...). As far as the other fields are concerned, the present way they are
reformatted is fine with me.

Thanks for maintainin roxygen2.

Johannes

Am Montag, 30. M�rz 2015, 07:15:02 schrieb Hadley Wickham:

Could you add a test for this? It's a bit tricky because you might also need
to preserve on output too - or maybe roxygen should be preserving
whitespace for all inputs?


Reply to this email directly or view it on GitHub:
#330 (comment)

hadley added a commit that referenced this issue Mar 30, 2015
Keep whitespace in Authors@R field
@hadley hadley merged commit f2b7c9d into r-lib:master Mar 30, 2015
1 check passed
@hadley
Copy link
Member

@hadley hadley commented Mar 30, 2015

Oops, forgot to ask for a sentence in the news too. Can you please create a new PR?

@jranke jranke deleted the authors_description branch Mar 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants