Allow missing space before @include #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please squash and add a bullet to NEWS? |
|
Resolved conflict, added bullet to NEWS. |
|
Squashed, too. |
hadley
added a commit
that referenced
this pull request
Oct 6, 2015
Allow missing space before @include
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inconsistent, other tags allow a space before @, but @include doesn't.
Includes a test.
There is code duplication, the detection of a roxygen comment is also encoded in
LINE.DELIMITER(code ref) but there the caret (start of text indicator) is missing. What to do about that?