Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't write blank namespace. Closes #276" #348

Merged
merged 2 commits into from Oct 6, 2015
Merged

Revert "Don't write blank namespace. Closes #276" #348

merged 2 commits into from Oct 6, 2015

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 2, 2015

This reverts commit cc6b8aa.

The shortcut is no more necessary, as roxygen2 won't overwrite files that do not include the "magic comment". On the other hand, the shortcut prevents creation of truly empty NAMESPACE files.

@hadley
Copy link
Member

@hadley hadley commented Oct 4, 2015

Thanks - can you please update NEWS and squash?

Kirill Müller added 2 commits Oct 6, 2015
This reverts commit cc6b8aa.

The shortcut is no more necessary, as roxygen2 won't overwrite files that do not include the "magic comment". On the other hand, the shortcut prevents creation of truly empty `NAMESPACE` files.
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Oct 6, 2015

Squashed and moved NEWS.

@hadley hadley merged commit 9878309 into r-lib:master Oct 6, 2015
1 check was pending
@hadley
Copy link
Member

@hadley hadley commented Oct 6, 2015

Thanks!

@krlmlr krlmlr deleted the empty-namespace branch Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants