Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call preref funcs for automatic tags in intro, closes #364 #370

Merged
merged 2 commits into from Oct 4, 2015
Merged

Call preref funcs for automatic tags in intro, closes #364 #370

merged 2 commits into from Oct 4, 2015

Conversation

@gaborcsardi
Copy link
Collaborator

@gaborcsardi gaborcsardi commented Aug 20, 2015

To address #364.

@gaborcsardi
Copy link
Collaborator Author

@gaborcsardi gaborcsardi commented Aug 20, 2015

Wait please, needs some more testing.

@gaborcsardi
Copy link
Collaborator Author

@gaborcsardi gaborcsardi commented Sep 15, 2015

@hadley I think it is good to go now. I run it through a couple of biggish packages, like devtools and igraph, and the docs are literally the same.

pieces <- rbind(desc, pieces, deparse.level = 0)

## Merge multiple @details tags, one might have come from the intro
didx <- which(pieces[,1] == "details")
Copy link
Member

@hadley hadley Sep 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that handled by line 82 below?

Copy link
Collaborator Author

@gaborcsardi gaborcsardi Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the comment is wrong there, actually. It would be slightly more difficult to handle it there. Now other_pieces is an input only in process_description, but not output. Handling it there would mean that you need to output/change it (remove or update the existing details field), and the output value of the function gets more messy. That's why I moved it up here.

Copy link
Collaborator Author

@gaborcsardi gaborcsardi Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the comment in a sec.

Copy link
Collaborator Author

@gaborcsardi gaborcsardi Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment fixed.

@gaborcsardi
Copy link
Collaborator Author

@gaborcsardi gaborcsardi commented Oct 3, 2015

@hadley could you please take another look? Thanks.

hadley added a commit that referenced this issue Oct 4, 2015
Call preref funcs for automatic tags in intro, closes #364
@hadley hadley merged commit 63fe2d2 into r-lib:master Oct 4, 2015
1 check passed
@hadley
Copy link
Member

@hadley hadley commented Oct 4, 2015

Thanks! Just to double check, this is a refactoring right? Otherwise we'll need a bullet in NEWS.

@gaborcsardi
Copy link
Collaborator Author

@gaborcsardi gaborcsardi commented Oct 4, 2015

Yes, actually, this a bug fix in the public API, strictly speaking, so I'll add a bullet to the NEWS.

hadley added a commit that referenced this issue Oct 5, 2015
NEWS, calling preref parsers for fields from intro, #370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants