Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never overwrite manually created NAMESPACE #436

Closed
wants to merge 2 commits into from
Closed

Never overwrite manually created NAMESPACE #436

wants to merge 2 commits into from

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 23, 2015

even when using roxygen2 for the first time.

A follow-up to #348, which works fine except for first-time usage of roxygen2.

@hadley
Copy link
Member

@hadley hadley commented Aug 29, 2016

Can you give a bit more detail about why this is the correct fix?

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Aug 29, 2016

I feel check is a misnomer, 3124846 renames the argument so that the action is more explicit.

@hadley
Copy link
Member

@hadley hadley commented Aug 31, 2016

Should I rename check to is_first? The generic isn't exported (yet) so I think it's fine to change the argument name.

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Aug 31, 2016

I'm updating the pull for the current codebase (to use is_first). I'm not entirely sure why the update behavior of roxygen2 should be any different for the first run.

@hadley
Copy link
Member

@hadley hadley commented Sep 7, 2016

Merged by hand in 596893c

@hadley hadley closed this Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants