Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace in more links #760

Merged
merged 3 commits into from Jul 24, 2018
Merged

Fix whitespace in more links #760

merged 3 commits into from Jul 24, 2018

Conversation

@jennybc
Copy link
Member

@jennybc jennybc commented Jul 16, 2018

Fixes #754 White space is not preserved when link-reference text is split over lines

Unfortunately I did this before I saw #754 and the related PR #755 馃様

In any case, I too extended @egnha's original solution for []() style links to also handle [][] links.
The PRs are very similar, so let this be taken as evidence that one them should be merged!

jennybc added a commit to r-lib/usethis that referenced this issue Jul 16, 2018
@hadley
Copy link
Member

@hadley hadley commented Jul 24, 2018

Could you please update the NEWS bullet too?

@jennybc
Copy link
Member Author

@jennybc jennybc commented Jul 24, 2018

Done.

@hadley hadley merged commit 4068897 into r-lib:master Jul 24, 2018
3 checks passed
@hadley
Copy link
Member

@hadley hadley commented Jul 24, 2018

Thanks!

@jennybc jennybc deleted the fix-link-ws branch Aug 7, 2018
hadley added a commit that referenced this issue Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants