Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify version of desc package #773

Merged
merged 2 commits into from Aug 21, 2018
Merged

Specify version of desc package #773

merged 2 commits into from Aug 21, 2018

Conversation

@crsh
Copy link
Contributor

@crsh crsh commented Aug 8, 2018

Running roxygenize() with desc 1.1.0 throws the following error:

Error in .f(.x[[i]], ...) : attempt to apply non-function

This is caused by read.description() trying to access the non-existent function get_field() in the output of desc() (see here). get_field() was only added to the output with version 1.2.0 of desc.

Running `roxygenize()` with `desc` 1.1.0 throws the following error:

~~~
Error in .f(.x[[i]], ...) : attempt to apply non-function
~~~

This is caused by `read.description()` trying to access the non-existent function `get_field()` in the output of `desc()` (see [here](https://github.com/klutometis/roxygen/blob/master/R/utils.R)). `get_field()` was only added to the output with [version 1.2.0](https://github.com/r-lib/desc/blob/4f60833fdb6d1aae4cbf09b7eb293c5fa0770e5c/inst/NEWS.md#120) of `desc`.
@hadley
Copy link
Member

@hadley hadley commented Aug 21, 2018

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@crsh
Copy link
Contributor Author

@crsh crsh commented Aug 21, 2018

Sure, I just added the commit.

@hadley hadley merged commit 7032ed1 into r-lib:master Aug 21, 2018
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants