Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display hex logo at 120px width #834

Merged
merged 4 commits into from Jul 23, 2019
Merged

Display hex logo at 120px width #834

merged 4 commits into from Jul 23, 2019

Conversation

@peterdesmet
Copy link
Contributor

@peterdesmet peterdesmet commented Dec 13, 2018

Roxygen currently checks if there is a (hex) logo available and adds this to the name-package.Rd file as:

\if{html}{\figure{logo.png}{options: align='right'}}

Positioning the logo on the right is also how pkgdown instructs to add the logo to the README (and thus pkgdown homepage), but there the logo also gets a width of 120px, so bigger logos still show nicely:

---
output: github_document
---

# pkgdown <img src="man/figures/logo.png" align="right" alt="" width="120" />

This PR:

  • Also sets the width at 120px, so logos display nicely independent of their size when doing ?package
  • Sets an alt='logo'. This is in contrast with pkgdown where alt is empty (which I consider an oversight)

Note: I wasn't sure if the syntax for options was space or comma separated. I used space.

Copy link
Member

@hadley hadley left a comment

Looks good! Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@peterdesmet
Copy link
Contributor Author

@peterdesmet peterdesmet commented Jul 23, 2019

@hadley thanks! Change is now described in NEWS.md: 7b2dd40

@hadley hadley merged commit dfef7dc into r-lib:master Jul 23, 2019
2 of 3 checks passed
@hadley
Copy link
Member

@hadley hadley commented Jul 23, 2019

Thanks!

@peterdesmet peterdesmet deleted the patch-1 branch Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants