Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of inheritDotParams #842

Merged
merged 12 commits into from Sep 13, 2019
Merged

Conversation

@halldc
Copy link
Contributor

@halldc halldc commented Jan 31, 2019

Fixes #730

That is, improve formatting for @inheritDotParams tag:

  • Add link to function
  • Wrap params in \code{}
Copy link
Contributor

@gustavdelius gustavdelius left a comment

This works very nicely.

@gustavdelius
Copy link
Contributor

@gustavdelius gustavdelius commented Apr 13, 2019

In new versions of R, the use of boolean vectors in if statements is deprecated and issues a warning ". Therefore you may want to replace your is.na(pkgs), which produces a boolean vector if pkgs is a vector by anyNA(pkgs).

@hadley
Copy link
Member

@hadley hadley commented Jul 22, 2019

Could you please use expect_known_output() to construct a small test that demonstrates how the new rendering looks?

@hadley hadley merged commit 6679484 into r-lib:master Sep 13, 2019
9 checks passed
@hadley
Copy link
Member

@hadley hadley commented Sep 13, 2019

Thanks @halldc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants