Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support level 1 headings in markdown #908

Merged
merged 5 commits into from Sep 13, 2019
Merged

Support level 1 headings in markdown #908

merged 5 commits into from Sep 13, 2019

Conversation

@gaborcsardi
Copy link
Collaborator

@gaborcsardi gaborcsardi commented Sep 13, 2019

They generate separate sections.

This PR is on top of #907.

I'll add docs later, once we make sure that this is what we want.

@gaborcsardi
Copy link
Collaborator Author

@gaborcsardi gaborcsardi commented Sep 13, 2019

Rebased.... it addition to the docs, I'll also add better tests for edge cases, like #909.

R/rd.R Outdated Show resolved Hide resolved
R/rd.R Outdated Show resolved Hide resolved
R/tag.R Outdated Show resolved Hide resolved
R/tag.R Show resolved Hide resolved
@hadley
Copy link
Member

@hadley hadley commented Sep 13, 2019

I just pushed a little tweak. I'll merge once you update the docs.

gaborcsardi and others added 4 commits Sep 13, 2019
They are supported in (well, after, really) selected
roxygen tags currently (see `tag_markdown_with_sections`
entries in rd.R).
We should not add empty fields in general.
@gaborcsardi gaborcsardi force-pushed the feature/md-sections branch from b4c4df0 to 90956d6 Sep 13, 2019
@gaborcsardi
Copy link
Collaborator Author

@gaborcsardi gaborcsardi commented Sep 13, 2019

OK, added short docs in the Rd formatting vignette.

@gaborcsardi
Copy link
Collaborator Author

@gaborcsardi gaborcsardi commented Sep 13, 2019

@hadley also rebased, so it is ready, I think.

@hadley hadley merged commit 13ebfc7 into master Sep 13, 2019
10 checks passed
@hadley hadley deleted the feature/md-sections branch Sep 13, 2019
@hadley
Copy link
Member

@hadley hadley commented Sep 13, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants