Support level 1 headings in markdown #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborcsardi
force-pushed
the
feature/md-sections
branch
from
7baf5aa to
ded3759
Compare
gaborcsardi
force-pushed
the
feature/md-sections
branch
from
ded3759 to
635c605
Compare
gaborcsardi
force-pushed
the
feature/md-sections
branch
from
635c605 to
11d37b9
Compare
|
Rebased.... it addition to the docs, I'll also add better tests for edge cases, like #909. |
hadley
reviewed
Sep 13, 2019
|
I just pushed a little tweak. I'll merge once you update the docs. |
They are supported in (well, after, really) selected roxygen tags currently (see `tag_markdown_with_sections` entries in rd.R).
We should not add empty fields in general.
gaborcsardi
force-pushed
the
feature/md-sections
branch
from
b4c4df0 to
90956d6
Compare
|
OK, added short docs in the Rd formatting vignette. |
|
@hadley also rebased, so it is ready, I think. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They generate separate sections.
This PR is on top of #907.
I'll add docs later, once we make sure that this is what we want.