Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_fix_root_file() is no longer exported #10

Closed
jennybc opened this issue May 11, 2016 · 2 comments
Closed

make_fix_root_file() is no longer exported #10

jennybc opened this issue May 11, 2016 · 2 comments

Comments

@jennybc
Copy link
Member

@jennybc jennybc commented May 11, 2016

make_fix_root_file() is mentioned in some docs and in some /dontrun{}'d examples. It looks like it was once exported, but is not currently.

https://github.com/krlmlr/rprojroot/blob/55e850ed618b6b775b915c63e2f31333b213dbdb/R/file.R#L12

https://github.com/krlmlr/rprojroot/blob/55e850ed618b6b775b915c63e2f31333b213dbdb/R/file.R#L28

I see this has also come up here https://github.com/krlmlr/rprojroot/issues/9#issuecomment-181187650.

krlmlr pushed a commit that referenced this issue May 12, 2016
- Remove unexported functions from documentation and examples (#10).
@krlmlr krlmlr closed this in 3d86bac May 12, 2016
@krlmlr
Copy link
Member

@krlmlr krlmlr commented May 12, 2016

Thanks for reporting! This is what happens if you rely too much on automated testing ;-)

krlmlr pushed a commit that referenced this issue May 13, 2016
- New root criterion , useful for creating accessors to a known path (#11).
- Clarify difference between `find_file()` and `make_fix_file()` in vignette (#9).
- Remove unexported functions from documentation and examples (#10).
krlmlr added a commit that referenced this issue Nov 6, 2016
- Compatibility
    - Compatible with R >= 3.0.0 with the help of the `backports` package.

- New root criteria
    - `is_remake_project` and `find_remake_root_file()` look for [remake](https://github.com/richfitz/remake) project (#17).
    - `is_testthat` and `find_testthat_root_file()` that looks for `tests/testthat` root (#14).
    - `from_wd`, useful for creating accessors to a known path (#11).

- Minor enhancement
    - Criteria can be combined with the `|` operator (#15).

- Documentation
    - Add package documentation with a few examples (#13).
    - Clarify difference between `find_file()` and `make_fix_file()` in vignette (#9).
    - Remove unexported functions from documentation and examples (#10).
    - Use `pkgdown` to create website.

- Testing
    - Use Travis instead of wercker. Travis tests three R versions, and OS X.
    - Improve AppVeyor testing.
@github-actions
Copy link

@github-actions github-actions bot commented Dec 8, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants