Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize projectile projects? #21

Closed
jennybc opened this issue Dec 22, 2016 · 4 comments
Closed

Recognize projectile projects? #21

jennybc opened this issue Dec 22, 2016 · 4 comments

Comments

@jennybc
Copy link
Member

@jennybc jennybc commented Dec 22, 2016

Might be closest analogue of seeking foo.Rproj for non-RStudio projects, e.g. ESS.

See also: https://github.com/krlmlr/here/issues/1

Hard to tell how much this would come up IRL though? Because it targets the intersection of "no rstudio", "not a package", and "no git". 🤔

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 22, 2016

I like the sentinel in krlmlr/here#1 as a general solution for niche new use cases, but I'd be happy to review a PR.

@jennybc
Copy link
Member Author

@jennybc jennybc commented Dec 24, 2016

the intersection of "no rstudio", "not a package", and "no git"

I suspect that is awfully close to the empty set. So I'll close this. If there is some enormous projectile user base, I assume you will hear from them!

@jennybc jennybc closed this Dec 24, 2016
@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 4, 2017

Let's add it anyway.

@krlmlr krlmlr reopened this Jan 4, 2017
@krlmlr krlmlr closed this in 7efe1b3 Jan 15, 2017
krlmlr added a commit that referenced this issue Jan 25, 2017
- New root criteria
    - `is_projectile_project` recognize projectile projects (#21).
    - `has_dir()` constructs root criteria that check for existence of a directory.
    - `is_git_root`, `is_svn_root` and `is_vcs_root` look for a version control system root (#19).

- New function
    - `get_root_desc()` returns the description of the criterion that applies to a given root, useful for composite criteria created with `|`.

- Minor enhancements
    - Improve formatting of alternative criteria (#18).
    - If root cannot be found, the start path is shown in the error message.

- Internal
    - The `$testfun` member of the `rprojroot` S3 class is now a list of functions instead of a function.
@github-actions
Copy link

@github-actions github-actions bot commented Dec 8, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants