Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

here(NA) treats NA as "NA" #66

Closed
moodymudskipper opened this issue Nov 15, 2019 · 4 comments · Fixed by #69
Closed

here(NA) treats NA as "NA" #66

moodymudskipper opened this issue Nov 15, 2019 · 4 comments · Fixed by #69
Labels
bug

Comments

@moodymudskipper
Copy link

I would expect the output of here::here(NA) to be NA, or maybe the same as here::here(), but not a path ending with the characters "NA"..
@krlmlr krlmlr transferred this issue from r-lib/here Nov 9, 2020
@krlmlr
Copy link
Member

krlmlr commented Nov 9, 2020

This will need importing fs to replace file.path() by fs::path() .

@krlmlr krlmlr added the bug label Nov 9, 2020
@krlmlr
Copy link
Member

krlmlr commented Nov 9, 2020

I wonder if we should throw an error if one of the inputs is NA?

@krlmlr
Copy link
Member

krlmlr commented Nov 9, 2020

Interestingly, NA -> "NA" doesn't seem to be documented in ?file.path . This could also be fixed upstream, I wouldn't hold my breath though.

@krlmlr krlmlr mentioned this issue Nov 10, 2020
Merged
krlmlr added a commit that referenced this issue Nov 10, 2020
@krlmlr
Merge pull request #69 from r-lib/b-66-na
1d8df8e 
- `find_root_file()` propagates `NA` values in path components (#66).
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate NA values r-lib/rprojroot
2 participants
@krlmlr @moodymudskipper