New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return absolute paths unchanged #59
Conversation
@krlmlr Makes sense and seems to be a great solution to dealing with a combination of absolute and relative paths. Thanks for working on it! |
@krlmlr |
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 81.25% 80.00% -1.25%
==========================================
Files 5 6 +1
Lines 192 185 -7
==========================================
- Hits 156 148 -8
- Misses 36 37 +1
Continue to review full report at Codecov.
|
Looks great, thanks a lot for your work, this will definitely improve my workflow. |
Thanks for your feedback! |
Looking good! Thanks! |
@krlmlr That makes sense to me. Thanks! |
If the first component is already an absolute path, everything is returned unchanged. This applies to
find_root_file()
and the criteria's "member functions".Fixes r-lib/here#34, fixes r-lib/here#31.
Closes #46.
@jthurner @StevenMMortimer @czeildi @lgaborini: Would that make {here} easier to use?
@yihui: What do you think about this approach for handling paths that are already absolute, in {here} and {rprojroot}?