Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release scales 1.0.0 #157

Closed
hadley opened this issue Jul 24, 2018 · 3 comments
Closed

Release scales 1.0.0 #157

hadley opened this issue Jul 24, 2018 · 3 comments

Comments

@hadley
Copy link
Member

@hadley hadley commented Jul 24, 2018

  • devtools::check_win_devel()
  • rhub::check_for_cran()
  • revdepcheck::revdep_check(num_workers = 4)
  • Polish NEWS
  • If new failures, update email.yml then revdepcheck::revdep_email_maintainers()
  • Bump version (in DESCRIPTION and NEWS)
  • devtools::check_win_devel() (again!)
  • devtools::submit_cran()
  • pkgdown::build_site()
  • Approve email
  • Tag release
  • Bump dev version
  • Write blog post
  • Tweet

Template from r-lib/usethis#338

@dpseidel

This comment has been minimized.

Copy link
Collaborator

@dpseidel dpseidel commented Jul 28, 2018

There were 5 new breaks. 1 due to changes to colour_ramp(), 1 due to changes to hue_pal() and 3 due to changes in the formatters, generally because they no longer accept character strings. All of these were minor and I have opened issues on each of their repositories -- would you like me to still do revdep_email() as well?

Otherwise there were 45/375 that either timed out or couldn't install because of compile error or other dependencies not on my computer and thus weren't tested. Also nearly every tested package took issue with my tinytex install so the vignettes spit a consistent latex warning, usually related to fonts - apologies for cluttering the output.

Otherwise, I say we're ready to submit! There were no issues on check_win_devel(). I'm going to send the final blog post draft to mara to proofread. Obviously it won't be posted until the package is on CRAN, so if you have thoughts let me know. Also I'm a little less clear on what the final steps "Approve email" and "tag release" entail.

Have a good weekend! Happy to finish this over it but also fine to put it off until Monday morning. Just let me know what you want done.

@hadley

This comment has been minimized.

Copy link
Member Author

@hadley hadley commented Jul 28, 2018

Can you please run revdepcheck::revdep_report_cran() and paste that it into cran-comments.md? You should include a brief description of the breaking changes, and what we've done to advise the maintainers (i.e. file github issues).

@dpseidel

This comment has been minimized.

Copy link
Collaborator

@dpseidel dpseidel commented Jul 28, 2018

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.