Pseudo-log transform

[lepennec]

Hi,

this is a simple implementation of the pseudo-log transform, a.k.a as the asinh transform. This is a transform which behaves as sign(x)*log(|x|) when x is large and as x when x is small. Such a transform was mentionned in the issue #48. I've added two parameters, one which is used to define when x is small or not and the other to mimic a logarithm with a different base than the natural one (exp(1)).

Erwan

[hadley]

Are you still interested in this PR?

[lepennec]

Yes. Let me know how I can help.

…

On Tue, Jun 5, 2018 at 7:26 PM, Hadley Wickham ***@***.***> wrote: Are you still interested in this PR? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#106 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgR6TbelQLNn1QFTjVsPqHPP0xyee7aks5t5r8_gaJpZM4QGqPP> .

[dpseidel]

Hi @lepennec

We need a couple small things before this is ready for merge:

• fix styling. Tidy code styling is easily accomplished with the package styler. In this case, the only thing that jumps out at me is that the function documentation should have a line between the title and the params for readability/consistent roxygen style.
• can you add a test for this transformation?
• can you add a NEWS bullet explaining the change?

Thanks! Let me know if I can help.

[dpseidel]

@lepennec,

One final thing: the pattern for test file naming is to match the test file name to the R file name (as usethis::use_test() does). So rather than "test-psuedo-log", the appropriate file name is "test-trans-numeric" and the context similarly matched, something like "Trans - numeric" . Thanks so much for your contribution and patience with this PR!

[codecov-io]

Codecov Report

Merging #106 into master will decrease coverage by 1.5%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   62.23%   60.73%   -1.51%     
==========================================
  Files          27       28       +1     
  Lines         858      848      -10     
==========================================
- Hits          534      515      -19     
- Misses        324      333       +9

Impacted Files	Coverage Δ
R/trans-numeric.r	24.52% <50%> (+9.14%)	⬆️
R/scale-continuous.r	81.81% <0%> (-9.85%)	⬇️
R/pal-gradient.r	57.14% <0%> (-9.53%)	⬇️
R/colour-manip.r	31.42% <0%> (-5.42%)	⬇️
R/scale-discrete.r	85.71% <0%> (-4.92%)	⬇️
R/bounds.r	67.27% <0%> (-3.22%)	⬇️
R/colour-mapping.r	81.87% <0%> (-1.95%)	⬇️
R/pal-brewer.r	70% <0%> (-1.43%)	⬇️
R/formatter.r	90% <0%> (-1.03%)	⬇️
R/breaks.r	50% <0%> (-0.75%)	⬇️
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d767915...6028e36. Read the comment docs.

[hadley]

Needs username

[hadley]

@dpseidel since the last change is small, can you please make it and merge?