Join GitHub today
updating comma_format, percent_format and unit_format #146
I think it's worth considering if we do want to add
... to each of the existing formatters. Would it be simpler (and easier to document) to simply tell people to use
number_format() if they need more control?
If I have to use
Regarding digits argument in
In the current implementation of
> comma(123.45678)  "123.4568" > comma(123.45678, digits = 0)  "123" > comma(123.45678, digits = 2)  "123" > comma(123.45678, digits = 5)  "123.46"
That behaviour is not very intuitive.
In addition, it will require some code to determine the corresponding value of
I could understand a
If we keep in mind that
Looks good. Just two small style fixes, and a news bullet, and it'll be good to merge.
A couple more tiny suggstions. Also need to fix the merge conflict, then I can merge.