New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`dollar_format()` rely on `number_format()` #148

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
2 participants
@larmarange
Contributor

larmarange commented Jul 7, 2018

This fixes #79

@hadley

LGTM, just needs news.

@larmarange

This comment has been minimized.

Contributor

larmarange commented Jul 8, 2018

OK, I will wait for #146 to be merged, as it will produce additional merge conflicts

@larmarange larmarange force-pushed the larmarange:dollar_format branch from 7185a87 to 17fdded Jul 9, 2018

@larmarange

This comment has been minimized.

Contributor

larmarange commented Jul 9, 2018

news bullet added and merge conflict solved

#' than `largest_with_cents` which by default is 100000.
#' If `accuracy` is not specified, values are rounded to the nearest cent,
#' and cents are displayed if any of the values has a non-zero cents and
#' the largest value is less #' than `largest_with_cents` which by default

This comment has been minimized.

@hadley

hadley Jul 9, 2018

Member

Missing newline before #?

This comment has been minimized.

@larmarange

larmarange Jul 10, 2018

Contributor

corrected

@larmarange larmarange force-pushed the larmarange:dollar_format branch from 17fdded to b853493 Jul 10, 2018

@larmarange

This comment has been minimized.

Contributor

larmarange commented Jul 10, 2018

merge conflict solved

@hadley hadley merged commit e7d1638 into r-lib:master Jul 23, 2018

3 checks passed

codecov/patch 100% of diff hit (target 68.37%)
Details
codecov/project 69.51% (+1.14%) compared to 419236a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment